Re: [Xen-devel] [PATCH 1/7] xen/arm: vpsci: Remove parameter 'ver' from do_common_cpu

[Julien Grall <julien.grall@xxxxxxx>]

On 06/02/18 15:42, Volodymyr Babchuk wrote:
> Hi Julien,
Hi Volodymyr,

> On 5 February 2018 at 15:20, Julien Grall <julien.grall@xxxxxxx> wrote:
> > Currently, the behavior of do_common_cpu will slightly change depending
> > on the PSCI version passed in parameter. Looking at the code, more the
> > specific 0.2 behavior could move out of the function or adapted for 0.1:
> >
> >      - x0/r0 can be updated on PSCI 0.1 because general purpose registers
> >      are undefined upon CPU on.
> >      - PSCI 0.1 does not defined PSCI_ALREADY_ON. However, it would be
> >      safer to bail out if the CPU is already on.
> >
> > Based on this, the parameter 'ver' is removed and do_psci_cpu_on
> > (implementation for PSCI 0.1) is adapted to avoid returning
> > PSCI_ALREADY_ON.
> >
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
Thank you for the reviewed. FIY, I moved that patch towards the end of 
the series as it is not necessary for backporting. I kept your 
reviewed-by because there are no clash.
I hope that is fine for you.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel