Re: [Xen-devel] [PATCH v4 5/8] ARM: VGIC: factor out vgic_connect_hw_irq()

[Julien Grall <julien.grall@xxxxxxx>]

On 02/06/2018 02:21 PM, Julien Grall wrote:
> Hi Andre,
>
> On 02/05/2018 04:19 PM, Andre Przywara wrote:
> > At the moment we happily access VGIC internal data structures like
> > the rank and struct pending_irq in gic.c, which should be VGIC agnostic.
> >
> > Factor out a new function vgic_connect_hw_irq(), which allows a virtual
> > IRQ to be connected to a hardware IRQ (using the hw bit in the LR).
> >
> > This removes said accesses to VGIC data structures and improves 
> > abstraction.
> I was expecting some explanation regarding the new locking order in the 
> commit message.
From a quick chat with Andre on IRC, it looks like figuring out the 
current locking might be tricky. So I would be happy if we only point 
out the change of locking (+ a word on the new locking) in the commit 
message.
This would help in case we find a regression later on.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel