Re: [Xen-devel] [PATCH v2 4/4] x86/emul: Improvements to internal users of decode_register()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 30.01.18 at 16:56, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/x86_emulate/x86_emulate.c
> +++ b/xen/arch/x86/x86_emulate/x86_emulate.c
> @@ -1957,9 +1957,8 @@ const uint8_t cpu_user_regs_gpr_offsets[] = {
>  #endif
>  };
>  
> -void *
> -decode_register(
> -    uint8_t modrm_reg, struct cpu_user_regs *regs, int highbyte_regs)
> +static void *decode_gpr_byteop(
> +    struct cpu_user_regs *regs, unsigned int modrm_reg, bool legacy_byteop)

Again I'm not really happy about "op" here. Why not follow the
model of my original patch and make this

static void *_decode_gpr(
    struct cpu_user_regs *regs, unsigned int modrm_reg, bool legacy)

? With that or a substantially similar adjustment
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel