Re: [Xen-devel] [PATCH v2 1/4] x86/emul: Introduce a test covering legacy byte ops

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 30.01.18 at 16:56, <andrew.cooper3@xxxxxxxxxx> wrote:
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
with one cosmetic remark:

> --- a/tools/tests/x86_emulator/test_x86_emulator.c
> +++ b/tools/tests/x86_emulator/test_x86_emulator.c
> @@ -442,6 +442,21 @@ int main(int argc, char **argv)
>          goto fail;
>      printf("okay\n");
>  
> +    printf("%-40s", "Testing xchgl %bl,%ah...");
> +    instr[0] = 0x86; instr[1] = 0xdc;
> +    regs.eflags = 0x200;

Please can we stop the bad habit of using hex numbers here (and
in the check below)? We have X86_EFLAGS_IF available after all.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel