Re: [Xen-devel] [PATCH 3/3] xen/arm: vpsci: Move PSCI function dispatching from vsmc.c to vpsci.c

[Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>]

Hi,

On 26.01.18 20:15, Julien Grall wrote:
> Hi,
>
> On 26/01/18 18:09, Volodymyr Babchuk wrote:
> > On 24.01.18 20:34, Julien Grall wrote:
> > > -    case PSCI_0_2_FN32(AFFINITY_INFO):
> > > -    case PSCI_0_2_FN64(AFFINITY_INFO):
> > > +    switch ( fid )
> > >       {
> > > -        register_t taff = PSCI_ARG(regs, 1);
> > > -        uint32_t laff = PSCI_ARG32(regs, 2);
> > > -
> > > -        perfc_incr(vpsci_cpu_affinity_info);
> > > -        PSCI_SET_RESULT(regs, do_psci_0_2_affinity_info(taff, laff));
> > > -        return true;
> > > -    }
> > > -
> > >       case ARM_SMCCC_FUNC_CALL_COUNT(STANDARD):
> > >           return fill_function_call_count(regs, 
> > > SSSC_SMCCC_FUNCTION_COUNT);
> > Now definition SSSC_SMCCC_FUNCTION_COUNT depends on code in vscpi.c.
> > Maybe it is time to introduce function get_psci_0_2_fn_count() and use 
> > it there, what do you think?
> Definitely not a function. It is a static number. But I can think of 
> separate the call count.
Yep, separate call count for vPSCI and for SSSC itself would be a good 
thing.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel