Re: [Xen-devel] [PATCH v3 4/7] kconfig/gcov: rename to coverage

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Jan 24, 2018 at 11:27:22AM +0000, Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH v3 4/7] kconfig/gcov: rename to coverage"):
> > So it can be used by both gcc and clang. Just add the Kconfig option
> > and modify the makefiles so the llvm coverage specific code can be
> > added in a follow up patch.
> ...
> > diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c
> > index f2ae6295ff..8e83c33a16 100644
> > --- a/xen/common/sysctl.c
> > +++ b/xen/common/sysctl.c
> > @@ -396,12 +396,10 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) 
> > u_sysctl)
> >      }
> >      break;
> >  
> > -#ifdef CONFIG_GCOV
> >      case XEN_SYSCTL_coverage_op:
> >          ret = sysctl_cov_op(&op->u.coverage_op);
> >          copyback = 1;
> >          break;
> > -#endif
> >  
> 
> This hunk seems erroneous ?  Surely the name should be updated, but
> the #ifdef should remain.
> 

No the ifdef needs to go.

There is a new stub introduced in this patch.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel