Re: [Xen-devel] [PATCH v4 6/6] x86/domctl: Remove XEN_DOMCTL_pin_mem_cacheattr

[Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>]

On 01/23/2018 03:44 PM, Wei Liu wrote:
> On Tue, Jan 23, 2018 at 03:22:46PM +0000, Ross Lagerwall wrote:
> > Remove the implementation of XEN_DOMCTL_pin_mem_cacheattr since it has
> > been replaced by a dmop. Change xc_domain_pin_memory_cacheattr() so
> > that it is only defined when XC_WANT_COMPAT_DEVICEMODEL_API is set and
> > have it call the new dmop.  Leave the definitions of
> > XEN_DOMCTL_MEM_CACHEATTR_* since they are still used by QEMU.
snip>> diff --git a/xen/include/public/domctl.h 
b/xen/include/public/domctl.h
> > index a8921dd..30674d6 100644
> > --- a/xen/include/public/domctl.h
> > +++ b/xen/include/public/domctl.h
> > @@ -38,7 +38,7 @@
> >   #include "hvm/save.h"
> >   #include "memory.h"
> >   
> > -#define XEN_DOMCTL_INTERFACE_VERSION 0x0000000f
> > +#define XEN_DOMCTL_INTERFACE_VERSION 0x00000010
> >   
> We bumped this to 0f in this development window so there is no need to
> do it again.
OK.

> >   /*
> >    * NB. xen_domctl.domain is an IN/OUT parameter for this operation.
> > @@ -598,10 +598,6 @@ struct xen_domctl_ioport_mapping {
> >   #define XEN_DOMCTL_MEM_CACHEATTR_WB  6
> >   #define XEN_DOMCTL_MEM_CACHEATTR_UCM 7
> >   #define XEN_DOMCTL_DELETE_MEM_CACHEATTR (~(uint32_t)0)
> Any reason to not remove these #define's?
They're still used by QEMU at the moment. Removing them now would break 
the build. They can be removed once QEMU(s) have been switch to use the 
new XEN_DMOP_* #defines.
--
Ross Lagerwall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel