Re: [Xen-devel] [RFC v4 2/8] xen/bitops: Rename LOG_2 to ilog2

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Sameer,

On 19/12/17 03:16, Sameer Goel wrote:
> Changing the name of the macro from LOG_2 to ilog2.This makes the function name
> similar to its Linux counterpart. Since, this is not used in mutiple places, so 
> the code churn is minimal.
s/mutiple/multiple/

> This change helps in porting unchanged code from Linux.
Can you wrap the commit message correctly?

Cheers,

> Signed-off-by: Sameer Goel <sameer.goel@xxxxxxxxxx>
> ---
>   xen/arch/x86/x86_64/asm-offsets.c | 2 +-
>   xen/include/xen/bitops.h          | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/x86/x86_64/asm-offsets.c 
> b/xen/arch/x86/x86_64/asm-offsets.c
> index e136af6b99..4bccbc9bdf 100644
> --- a/xen/arch/x86/x86_64/asm-offsets.c
> +++ b/xen/arch/x86/x86_64/asm-offsets.c
> @@ -157,7 +157,7 @@ void __dummy__(void)
>       BLANK();
>   #endif
>   
> -    DEFINE(IRQSTAT_shift, LOG_2(sizeof(irq_cpustat_t)));
> +    DEFINE(IRQSTAT_shift, ilog2(sizeof(irq_cpustat_t)));
>       OFFSET(IRQSTAT_softirq_pending, irq_cpustat_t, __softirq_pending);
>       BLANK();
>   
> diff --git a/xen/include/xen/bitops.h b/xen/include/xen/bitops.h
> index e2019b02a3..a103e49089 100644
> --- a/xen/include/xen/bitops.h
> +++ b/xen/include/xen/bitops.h
> @@ -223,7 +223,7 @@ static inline __u32 ror32(__u32 word, unsigned int shift)
>   #define __L4(_x)  (((_x) & 0x0000000c) ? ( 2 + __L2( (_x)>> 2)) : __L2( _x))
>   #define __L8(_x)  (((_x) & 0x000000f0) ? ( 4 + __L4( (_x)>> 4)) : __L4( _x))
>   #define __L16(_x) (((_x) & 0x0000ff00) ? ( 8 + __L8( (_x)>> 8)) : __L8( _x))
> -#define LOG_2(_x) (((_x) & 0xffff0000) ? (16 + __L16((_x)>>16)) : __L16(_x))
> +#define ilog2(_x) (((_x) & 0xffff0000) ? (16 + __L16((_x)>>16)) : __L16(_x))
>   
>   /**
>    * for_each_set_bit - iterate over every set bit in a memory region
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel