Re: [Xen-devel] [PATCH v3 6/6] x86/domctl: Remove XEN_DOMCTL_pin_mem_cacheattr

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.01.18 at 13:45, <ross.lagerwall@xxxxxxxxxx> wrote:
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -597,10 +597,6 @@ struct xen_domctl_ioport_mapping {
>  #define XEN_DOMCTL_MEM_CACHEATTR_WB  6
>  #define XEN_DOMCTL_MEM_CACHEATTR_UCM 7
>  #define XEN_DOMCTL_DELETE_MEM_CACHEATTR (~(uint32_t)0)
> -struct xen_domctl_pin_mem_cacheattr {
> -    uint64_aligned_t start, end;
> -    uint32_t type; /* XEN_DOMCTL_MEM_CACHEATTR_* */
> -};
>  
>  
>  /* XEN_DOMCTL_set_ext_vcpucontext */
> @@ -1148,7 +1144,7 @@ struct xen_domctl {
>  #define XEN_DOMCTL_bind_pt_irq                   38
>  #define XEN_DOMCTL_memory_mapping                39
>  #define XEN_DOMCTL_ioport_mapping                40
> -#define XEN_DOMCTL_pin_mem_cacheattr             41
> +/* #define XEN_DOMCTL_pin_mem_cacheattr          41 Obsolete - use dmop */

"Obsolete" is wrong imo if the implementation is gone. Also I think
you need to bump the interface version when you remove
something here.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel