Re: [Xen-devel] [PATCH RFC v1 23/74] x86/entry: Probe for Xen early during boot

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Jan 11, 2018 at 12:55:48AM -0700, Jan Beulich wrote:
> >>> On 10.01.18 at 18:45, <wei.liu2@xxxxxxxxxx> wrote:
> > On Fri, Jan 05, 2018 at 06:40:29AM -0700, Jan Beulich wrote:
> >> >>> On 04.01.18 at 14:05, <wei.liu2@xxxxxxxxxx> wrote:
> >> > --- a/xen/include/asm-x86/guest.h
> >> > +++ b/xen/include/asm-x86/guest.h
> >> > @@ -20,6 +20,7 @@
> >> >  #define __X86_GUEST_H__
> >> >  
> >> >  #include <asm/guest/pvh-boot.h>
> >> > +#include <asm/guest/xen.h>
> >> >  
> >> >  #endif /* __X86_GUEST_H__ */
> >> 
> >> I'm increasingly curious to understand what this header's purpose
> >> is meant to be. It looks as if you mean source files to only ever
> >> include this one, but why? Rather than exposing everything at
> > 
> > Yes there will be file that only includes this header -- the PV in HVM
> > work doesn't need the PVH bits.
> 
> Either I'm not understanding your reply or you didn't understand
> mine: I was trying to understand the purpose of guest.h if it
> consists of only #include-s. In such a case, why can't the sources
> needing certain bits simply include the headers they need, instead
> of this container one?

I see. Yes this header can go away. This is going to be a nice-to-have
in my book, i.e. I will do it later.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel