Re: [Xen-devel] [Makefile] asm: handle comments when creating header file

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 10.01.18 at 16:14, <nmanthey@xxxxxxxxxx> wrote:
> In the early steps of compilation, the asm header files are created, such
> as include/asm-$(TARGET_ARCH)/asm-offsets.h. These files depend on the
> assembly file arch/$(TARGET_ARCH)/asm-offsets.s, which is generated
> before. Depending on the used assembler, there might be comments in the
> assembly files.
> 
> This commit adds handling comments in the assembler during the creation of
> the asm header files.

I have a hard time seeing how ...

> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -189,7 +189,7 @@ include/asm-$(TARGET_ARCH)/asm-offsets.h: 
> arch/$(TARGET_ARCH)/asm-offsets.s
>         echo "#ifndef __ASM_OFFSETS_H__"; \
>         echo "#define __ASM_OFFSETS_H__"; \
>         echo ""; \
> -       sed -rne "/==>/{s:.*==>(.*)<==.*:\1:; s: [\$$#]: :; p;}"; \

... this pattern could match any comment that we currently have.
Would you mind clarifying what it is that is actually broken (and
hence wants/needs fixing)?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel