Re: [Xen-devel] [PATCH RFC v1 53/74] xen/pvshim: modify Dom0 builder in order to build a DomU

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.01.18 at 14:06, <wei.liu2@xxxxxxxxxx> wrote:
> +void __init pv_shim_setup_dom(struct domain *d, l4_pgentry_t *l4start,
> +                              unsigned long va_start, unsigned long store_va,
> +                              unsigned long console_va, unsigned long 
> vphysmap,
> +                              start_info_t *si)
> +{
> +    uint64_t param = 0;
> +    long rc;
> +
> +#define SET_AND_MAP_PARAM(p, si, va) ({                                      
>   \
> +    rc = xen_hypercall_hvm_get_param(p, &param);                             
>   \
> +    if ( rc )                                                                
>   \
> +        panic("Unable to get " #p "\n");                                     
>   \
> +    (si) = param;                                                            
>   \
> +    if ( va )                                                                
>   \
> +    {                                                                        
>   \
> +        BUG_ON(unshare_xen_page_with_guest(mfn_to_page(param), dom_io));     
>   \
> +        share_xen_page_with_guest(mfn_to_page(param), d, XENSHARE_writable); 
>   \
> +        replace_va(d, l4start, va, param);                                   
>   \
> +        dom0_update_physmap(d, (va - va_start) >> PAGE_SHIFT, param, 
> vphysmap);\

Cosmetic remark: va wants to be parenthesized here.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel