Re: [Xen-devel] [PATCH v2 06/23] console: do not print banner if below info log threshold

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Sun, Jan 07, 2018 at 12:28:22PM -0800, Anthony Liguori wrote:
> From: Anthony Liguori <aliguori@xxxxxxxxxx>
> 
> Only print the banner if the log threshold is at least info.
> 
> For Vixen guests, we want the console output to be exactly what the
> PV guest would show on it's own.  That means the inner Xen banner
> can potentially break automation that assumes a specific type of
> console output.

:-)

> 
> Signed-off-by: Anthony Liguori <aliguori@xxxxxxxxxx>

> ---
>  xen/drivers/char/console.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
> index 0f85707..3eb130d 100644
> --- a/xen/drivers/char/console.c
> +++ b/xen/drivers/char/console.c
> @@ -812,9 +812,12 @@ void __init console_init_preirq(void)
>      serial_set_rx_handler(sercon_handle, serial_rx);
>  
>      /* HELLO WORLD --- start-of-day banner text. */
> -    spin_lock(&console_lock);
> -    __putstr(xen_banner());
> -    spin_unlock(&console_lock);
> +    if ( 2 < xenlog_lower_thresh ) {

This should become a tunable (command line option?) instead of being
hardcoded.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel