Re: [Xen-devel] [PATCH v2] x86: implement cpu_possible_map

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.12.17 at 18:25, <roger.pau@xxxxxxxxxx> wrote:
> On x86 cpu_possible_map is not defined, so trying to use
> num_possible_cpus will generate link time errors.

I think this makes sense only in connection with a patch actually
requiring the symbol. The variable isn't there on x86 (anymore
iirc) for the very reason that the last user has long gone.

> @@ -1474,11 +1475,14 @@ void __init noreturn __start_xen(unsigned long mbi_p)
>      {
>          max_cpus = 0;
>          set_nr_cpu_ids(1);
> +        __cpumask_set_cpu(0, &cpu_possible_map);
>      }
>      else
>      {
>          set_nr_cpu_ids(max_cpus);
>          max_cpus = nr_cpu_ids;
> +        for ( i = 0; i < nr_cpu_ids; i++ )
> +            __cpumask_set_cpu(i, &cpu_possible_map);
>      }

Considering this - why can't you use nr_cpu_ids instead of
num_possible_cpus?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel