Re: [Xen-devel] [PATCH v9.1 06/16] x86: implement get hw info flow for MBA

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.12.17 at 09:30, <yi.y.sun@xxxxxxxxxxxxxxx> wrote:
> This patch implements get HW info flow for MBA including its callback
> function and sysctl interface.
> 
> Signed-off-by: Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx>
> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

As said before (a number of times I think), tags need to be dropped
when you fix bugs. This imo similarly applies to the 9.1 tools patch.

> --- a/xen/arch/x86/sysctl.c
> +++ b/xen/arch/x86/sysctl.c
> @@ -174,10 +174,10 @@ long arch_do_sysctl(
>      case XEN_SYSCTL_psr_alloc:
>          switch ( sysctl->u.psr_alloc.cmd )
>          {
> -            uint32_t data[PSR_INFO_ARRAY_SIZE];
> -
>          case XEN_SYSCTL_PSR_get_l3_info:
>          {
> +            uint32_t data[PSR_INFO_ARRAY_SIZE] = { };
> +
>              ret = psr_get_info(sysctl->u.psr_alloc.target,
>                                 PSR_TYPE_L3_CBM, data, ARRAY_SIZE(data));
>              if ( ret )
> @@ -197,6 +197,8 @@ long arch_do_sysctl(
>  
>          case XEN_SYSCTL_PSR_get_l2_info:
>          {
> +            uint32_t data[PSR_INFO_ARRAY_SIZE] = { };
> +
>              ret = psr_get_info(sysctl->u.psr_alloc.target,
>                                 PSR_TYPE_L2_CBM, data, ARRAY_SIZE(data));
>              if ( ret )
> @@ -214,6 +216,27 @@ long arch_do_sysctl(
>              break;
>          }
>  
> +        case XEN_SYSCTL_PSR_get_mba_info:
> +        {
> +            uint32_t data[PSR_INFO_ARRAY_SIZE] = { };

Please avoid such redundancy - move the declaration _out_ by one
scope (into one to be introduced at the case XEN_SYSCTL_psr_alloc
level) instead. I'd also appreciate if you cleaned up the pointless
braces which patch context above shows.

Also please re-send the whole remaining part of the series.
Together with there already having been a 9.1 for some other
patch in the series, I'd really like to see a clean v10 instead.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel