[Xen-devel] libxenstat_linux.c xenstat_collect_networks regression

[Bas Westerbaan <bas@xxxxxxxxxxxxxxx>]

Hi,

I just upgraded from 4.4 to 4.8 (going from Debian jessie to stretch) and hit a 
problem with xentop.  On 4.8 xentop shows only zeroes for network traffic.

I did some debugging and the problem appears to be that in 
xenstat_collect_networks (in libxenstat_linux.c) the following conditional is 
true

        if ((strstr(iface, devBridge) != NULL) &&
            (strstr(iface, devNoBridge) == NULL) &&
            ((domain = xenstat_node_domain(node, 0)) != NULL)) {

I use vif-route, so I have no bridge: devBridge points to an array of \0s.  So 
strstr says this empty string is a substring of vifn.0. Then it seems to act as 
if I am actually using a bridge and fails.

As a workaround I replaced the conditional with

        if ((devBridge[0] != 0) &&
            (strstr(iface, devBridge) != NULL) &&
            (strstr(iface, devNoBridge) == NULL) &&
            ((domain = xenstat_node_domain(node, 0)) != NULL)) {

This solved the problem for me, although I’m not sure at all if this solution 
is correct in general.

Best,

 Bas
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel