Re: [Xen-devel] [PATCH] xen/arm: domain_builder: irq sanity check logic fix

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 11/28/2017 07:03 PM, Julien Grall wrote:
> Hi Stewart,
Hi,

> On 11/28/2017 02:42 PM, Stewart Hildebrand wrote:
> > It's not possible for an irq to be both below 16 and greater/equal 
> > than 32.
> > Also fix the reference to linux documentation while we're at it.
> >
> > Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxxxxxxxxxx>
> Whoops. Well spotted!
>
> Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx>
>
> Also, I think it would be good to get the patch merge in Xen 4.10. It is 
> boot code and low risk. So:
Sadly this patch break boot on all ARM platform. Looking at the code, 
there is one caller which use ~0 for the IRQ.
This is to create a placeholder property for the event channel IRQ. The 
property is then replaced inplace. I think it would be possible to defer 
the creation of the property until we find the event channel IRQ. This 
would avoid the placeholder.
I will try to send a patch soon, though it will target Xen 4.11. So even 
if the patch was valid, I asked to revert it. Sorry for that.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel