Re: [Xen-devel] [Qemu-devel] [PATCH v2 1/6] machine: Replace has_dynamic_sysbus with list of allowed devices

[Eduardo Habkost <ehabkost@xxxxxxxxxx>]

On Tue, Nov 28, 2017 at 05:55:15PM +0100, Marc-André Lureau wrote:
[...]
> Hi
> 
> On Sat, Nov 25, 2017 at 4:16 PM, Eduardo Habkost <ehabkost@xxxxxxxxxx> wrote:
> > The existing has_dynamic_sysbus flag makes the machine accept
> > every user-creatable sysbus device type on the command-line.
> > Replace it with a list of allowed device types, so machines can
> > easily accept some sysbus devices while rejecting others.
> >
> > To keep exactly the same behavior as before, the existing
> > has_dynamic_sysbus=true assignments are replaced with a
> > TYPE_SYS_BUS_DEVICE entry on the allowed list.  Other patches
> > will replace the TYPE_SYS_BUS_DEVICE entries with more specific
> > lists of devices.
> >
> > Cc: Peter Maydell <peter.maydell@xxxxxxxxxx>
> > Cc: Marcel Apfelbaum <marcel@xxxxxxxxxx>
> > Cc: "Michael S. Tsirkin" <mst@xxxxxxxxxx>
> > Cc: Alexander Graf <agraf@xxxxxxx>
> > Cc: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>
> > Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>
> > Cc: qemu-arm@xxxxxxxxxx
> > Cc: qemu-ppc@xxxxxxxxxx
> > Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
> > Signed-off-by: Eduardo Habkost <ehabkost@xxxxxxxxxx>
> 
> Reviewed-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>

Thanks!

[...]
> > -    mc->has_dynamic_sysbus = true;
> > +    /*TODO: allow only sysbus devices that really work with this machine */
> 
> cosmetic: why do you not leave a space between * and TODO ? (you did
> that repeatedly)

Good question.  :)

For reasons I can't explain, I thought "/*TODO:" was more common
than "/* TODO:", but I was mistaken.  I will change this to
"/* TODO:" when committing the patches.

-- 
Eduardo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel