Re: [Xen-devel] [BUG] Error applying XSA240 update 5 on 4.8 and 4.9 (patch 3 references CONFIG_PV_LINEAR_PT, 3285e75dea89, x86/mm: Make PV linear pagetables optional)

[Steven Haigh <netwiz@xxxxxxxxx>]

On Thursday, 16 November 2017 8:30:39 PM AEDT Jan Beulich wrote:
> >>> On 15.11.17 at 23:48, <lists@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> > Hi,
> > 
> > I am having trouble applying the patch 3 from XSA240 update 5 for xen
> > stable 4.8 and 4.9
> > xsa240 0003 contains:
> > 
> > CONFIG_PV_LINEAR_PT
> > 
> > from:
> > 
> > x86/mm: Make PV linear pagetables optional
> > https://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=3285e75dea89afb0e
> > f5 b3ee39bd15194bd7cc110
> > 
> > I cannot find this string in an XSA, nor is an XSA referenced in the
> > commit.
> > Am I missing a patch, or doing something wrong?
> 
> Well, you're expected to apply all patched which haven't been
> applied so far. In particular, in the stable version trees, the 2nd
> patch hasn't gone in yet (I'm intending to do this later today),
> largely because it (a) wasn't ready at the time the first patch
> went in and (b) it is more a courtesy patch than an actual part of
> the security fix.

I'm not quite sure this is a great idea... They should work on the released 
versions - hence xsa240 patchset should apply to the base tarball + current 
XSA patches. If there is something in the git that *isn't* in the latest 
release, it should be included in the XSA patchset - otherwise the set is 
incomplete.

I don't see mention of anywhere in the written XSA that mentions a separate 
patch is required outside of the patches included with the XSA.

Could I suggest that we re-do v6 of these patches with the complete required 
set?

These should be included in 4.9.1 - which makes most things irrelevant - but 
I'm not aware of what the release window is for 4.9.1.

-- 
Steven Haigh

📧 netwiz@xxxxxxxxx       💻 http://www.crc.id.au
📞 +61 (3) 9001 6090    📱 0412 935 897

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel