Re: [Xen-devel] [llvm-dev] [PATCH for-next 7/9] coverage: introduce support for llvm profiling

[Vedant Kumar <vsk@xxxxxxxxx>]

- llvm-dev, since the code review can continue without that audience.

vedant

> On Nov 8, 2017, at 3:08 AM, Jan Beulich via llvm-dev 
> <llvm-dev@xxxxxxxxxxxxxx> wrote:
> 
>>>> On 08.11.17 at 09:56, <roger.pau@xxxxxxxxxx> wrote:
>> On Wed, Nov 08, 2017 at 01:38:59AM -0700, Jan Beulich wrote:
>>>>>> On 26.10.17 at 11:19, <roger.pau@xxxxxxxxxx> wrote:
>>>> --- a/xen/include/public/sysctl.h
>>>> +++ b/xen/include/public/sysctl.h
>>>> @@ -646,6 +646,12 @@ struct xen_sysctl_scheduler_op {
>>>> 
>>>> #define XEN_GCOV_FORMAT_MAGIC    0x58434f56 /* XCOV */
>>> 
>>> Hmm, shouldn't the private magic #define-s actually be put here
>>> (in which case you'd indeed need to retain both 32- and 64-bit
>>> variants)?
>> 
>> I don't think so, here XEN_GCOV_FORMAT_MAGIC is a Xen specific gcov
>> magic number.
>> 
>> OTOH LLVM_PROFILE_MAGIC_{64/32} is an llvm defined magic number,
>> that's not under our control. Hence I don't think it should be
>> exported in Xen public headers.
> 
> Okay.
> 
> Jan
> 
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev@xxxxxxxxxxxxxx
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel