[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH v2] osstest: fix rm to use '-f' in ts-freebsd-host-install



It's perfectly valid for the .tmp file to not exists, and the script
shouldn't fail in that case.

Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
---
Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
---
Changes since v1:
 - Use -f instead of removing the 'rm', osstest might want to wipe
   the file in order to not preserve the permissions.
---
 ts-freebsd-host-install | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ts-freebsd-host-install b/ts-freebsd-host-install
index 447a5076..573245ad 100755
--- a/ts-freebsd-host-install
+++ b/ts-freebsd-host-install
@@ -96,7 +96,7 @@ targetpath=$4
 cd $basedir
 mkdir -p `dirname $sharedpath`
 if [ ! -f $sharedpath ]; then
-    rm $sharedpath.tmp
+    rm -f $sharedpath.tmp
     dd if=$imagepath of=$sharedpath.tmp
     mv $sharedpath.tmp $sharedpath
 fi
-- 
2.13.6 (Apple Git-96)


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.