Re: [Xen-devel] [PATCH v1 4/5] tools: libxendevicemodel: Provide xendevicemodel_add_to_physmap

[Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>]

On 10/27/2017 12:45 PM, Wei Liu wrote:
> On Fri, Oct 20, 2017 at 10:22:55AM +0100, Paul Durrant wrote:
...
> > >  CFLAGS   += -Werror -Wmissing-prototypes
> > > diff --git a/tools/libs/devicemodel/core.c b/tools/libs/devicemodel/core.c
> > > index b66d4f9..2a23077 100644
> > > --- a/tools/libs/devicemodel/core.c
> > > +++ b/tools/libs/devicemodel/core.c
> > > @@ -564,6 +564,23 @@ int xendevicemodel_shutdown(
> > >      return xendevicemodel_op(dmod, domid, 1, &op, sizeof(op));
> > >  }
> > >
> > > +int xendevicemodel_add_to_physmap(
> > > +    xendevicemodel_handle *dmod, domid_t domid, uint64_t idx, uint64_t
> > > gpfn)
> > Do you really want this to be single page? Populating VRAM is not going to be 
> > fast if you need to make 16MB / 4K hypercalls to do it.
> This. Since we're introducing a new interface please consider giving it
> the ability to batch.
Yes indeed. I sent a v2 of this patch series a few days ago which 
changes it to operate on a range.
--
Ross Lagerwall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel