Re: [Xen-devel] [OSSTEST PATCH 11/16] ts-debian-fixup: use correct resume device

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Oct 20, 2017 at 02:20:29PM +0100, Ian Jackson wrote:
> Wei Liu writes ("Re: [OSSTEST PATCH 11/16] ts-debian-fixup: use correct 
> resume device"):
> > I wouldn't call this behaviour a bug.  Most people won't notice it
> > because the guest will boot eventually. It is not like this will cause
> > the guest to crash.
> 
> I don't think the guest booting "eventually" after some timeout is
> correct.
>

The OS is honoring whatever is written in the resume file. That's the
correct behaviour to me.

Booting after trying is better than not booting at all.  That parameter
isn't vital to a functional system. This has always been the case since
forever. It is only the "timeout" in the past is shorter so osstest
never noticed it.

What is not correct is the content of the file. We can't blame the guest
OS for that.

> > There is no option in xen-create-image to manipulate extra=. The only
> > viable solution is to provide a new template. That seems overkill and
> > would require more code.
> 
> What you're saying is that this infelicity in xen-tools is not
> particularly easy to fix.  That doesn't mean it shouldn't be reported
> as a bug.

There is nothing to fix. System administrator should provide a proper
template -- that's what xen-tools developers most likely to say.

It would require a lot more code in osstest to fix the template, and the
essence of such patch would still be the same.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel