Re: [Xen-devel] [PATCH V3 25/29] x86/vmsi: Hook delivering remapping format msi to guest

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.10.17 at 18:07, <roger.pau@xxxxxxxxxx> wrote:
> On Thu, Sep 21, 2017 at 11:02:06PM -0400, Lan Tianyu wrote:
>> diff --git a/xen/drivers/passthrough/io.c b/xen/drivers/passthrough/io.c
>> index 6196334..349a8cf 100644
>> --- a/xen/drivers/passthrough/io.c
>> +++ b/xen/drivers/passthrough/io.c
>> @@ -942,21 +942,20 @@ static void __msi_pirq_eoi(struct hvm_pirq_dpci 
>> *pirq_dpci)
>>  static int _hvm_dpci_msi_eoi(struct domain *d,
>>                               struct hvm_pirq_dpci *pirq_dpci, void *arg)
>>  {
>> -    int vector = (long)arg;
>> +    uint8_t vector, dlm, vector_target = (long)arg;
> 
> Since you are changing this, please cast to (uint8_t) instead.

That would cause a compiler warning - long (or unsigned long) is
the right type to use (on Xen and Linux at least) when wanting to
convert a pointer to an integer.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel