Re: [Xen-devel] [PATCH] tools/Makefile: unset MAKELEVEL before building QEMU

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Anthony PERARD writes ("[PATCH] tools/Makefile: unset MAKELEVEL before building 
QEMU"):
> Since QEMU commits aef45d51d1204f3335fb99de6658e0c5612c2b67
> "build: automatically handle GIT submodule checkout for dtc"
> the QEMU makefiles rely on the variable MAKELEVEL to make a decision on
> whether to update some git submodules or not. Since we call QEMU build
> from within the Xen one, MAKELEVEL would already be greater than 0 and
> the git submodules would not be updated and QEMU would fail to build.
> 
> Fix this by removing MAKELEVEL from the environment before trying to
> build QEMU.

Urgh.

I think this is a bug in the qemu makefiles.  But also, use of git
submodules is a bug in itself.  None of that is likely to be fixed.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel