[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] arm: configure interrupts to be in non-secure group1
Hi,
On 10/17/2017 10:32 PM, Stefano Stabellini wrote:
Xen uses non-secure group1 interrupts, however it doesn't configure the
GICv3 accordingly. Xen needs to set GICD_IGROUPR for SPIs and
GICR_IGROUPR0 for local interrupt to "1" to specify that interrupts
belong to group1. This is particularly important if the system has
GICD_CTLR.DS set, also see commit
7c9b973061b03af62734f613f6abec46c0dd4a88 in Linux.
Signed-off-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
---
This is a candidate for stable backports.
diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
index 74d00e0..196cfc5 100644
--- a/xen/arch/arm/gic-v3.c
+++ b/xen/arch/arm/gic-v3.c
@@ -569,6 +569,9 @@ static void __init gicv3_dist_init(void)
for ( i = NR_GIC_LOCAL_IRQS; i < nr_lines; i += 32 )
writel_relaxed(0xffffffff, GICD + GICD_ICENABLER + (i / 32) * 4);
+ for ( i = NR_GIC_LOCAL_IRQS; i < nr_lines; i += 32 )
+ writel_relaxed(0xffffffff, GICD + GICD_IGROUPR + (i / 32) * 4);
Can you please have a comment on top of this and ...
+
gicv3_dist_wait_for_rwp();
/* Turn on the distributor */
@@ -775,6 +778,7 @@ static int gicv3_cpu_init(void)
*/
writel_relaxed(0xffff0000, GICD_RDIST_SGI_BASE + GICR_ICENABLER0);
writel_relaxed(0x0000ffff, GICD_RDIST_SGI_BASE + GICR_ISENABLER0);
+ writel_relaxed(0xffffffff, GICD_RDIST_SGI_BASE + GICR_IGROUPR0);
.. this as Linux does to explain why setting to GRP1. Also please switch
to ~0 or use GENMASK(...).
gicv3_redist_wait_for_rwp();
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel
|
