Re: [Xen-devel] [PATCH] mm/shadow: fix declaration of fetch_type_names

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi,

On 17/10/17 11:29, Andrew Cooper wrote:
> On 17/10/17 11:23, Roger Pau Monne wrote:
> > fetch_type_names usage is guarded by SHADOW_DEBUG_PROPAGATE in
> > SHADOW_DEBUG, fix the declaration so it's also guarded by
> > SHADOW_DEBUG_PROPAGATE instead of DEBUG_TRACE_DUMP.
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Possibly worth noting that this is exposed by Clang when building with
> UBSAN ?
>
> Either way, thanks for getting to the bottom of this issue.  (It's been
> on my TODO list to figure out for a rather long time.)
>
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, and I agree that
> this should go into 4.10.
Release-acked-by: Julien Grall <julien.grall@xxxxxxxxxx>

Cheers,

> > ---
> > Cc: Tim Deegan <tim@xxxxxxx>
> > Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> > Cc: Jan Beulich <jbeulich@xxxxxxxx>
> > Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > Cc: Julien Grall <julien.grall@xxxxxxxxxx>
> > ---
> > IMHO, this is a simple compile-time fix, so it should be accepted for
> > 4.10. Any breaking caused by this commit will be spotted at compile
> > time.
> > ---
> >   xen/arch/x86/mm/shadow/multi.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/xen/arch/x86/mm/shadow/multi.c b/xen/arch/x86/mm/shadow/multi.c
> > index d540af11d7..9156382056 100644
> > --- a/xen/arch/x86/mm/shadow/multi.c
> > +++ b/xen/arch/x86/mm/shadow/multi.c
> > @@ -77,7 +77,7 @@ typedef enum {
> >   
> >   extern const char *const fetch_type_names[];
> >   
> > -#if defined(DEBUG_TRACE_DUMP) && CONFIG_PAGING_LEVELS == GUEST_PAGING_LEVELS
> > +#if SHADOW_DEBUG_PROPAGATE && CONFIG_PAGING_LEVELS == GUEST_PAGING_LEVELS
> >   const char *const fetch_type_names[] = {
> >       [ft_prefetch]     = "prefetch",
> >       [ft_demand_read]  = "demand read",
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> https://lists.xen.org/xen-devel
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel