Re: [Xen-devel] [PATCH 1/2] x86/boot: fix early error display

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 12/10/2017 21:50, Doug Goldstein wrote:
> From: David Esler <drumandstrum@xxxxxxxxx>
>
> In 9180f5365524 a change was made to the send_chr function to take in
> C-strings and print out a character at a time until a NULL was
> encountered. However there is no code to increment the current character
> position resulting in an endless loop of the first character. This adds
> a simple increment.
>
> Reviewed-by: Doug Goldstein <cardoe@xxxxxxxxxx>
> Signed-off-by: David Esler <drumandstrum@xxxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

CC'ing Julien as release manager. This should be included in 4.10 IMO,
and is a backport candidate.

> ---
>  xen/arch/x86/boot/head.S | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S
> index fd6fc337fe..f48bbbd2e5 100644
> --- a/xen/arch/x86/boot/head.S
> +++ b/xen/arch/x86/boot/head.S
> @@ -174,6 +174,7 @@ not_multiboot:
>          mov     sym_esi(vga_text_buffer),%edi
>  .Lsend_chr:
>          mov     (%esi),%bl
> +        inc     %esi
>          test    %bl,%bl        # Terminate on '\0' sentinel
>          je      .Lhalt
>          mov     $0x3f8+5,%dx   # UART Line Status Register


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel