Re: [Xen-devel] [PATCH v3] x86: psr: support co-exist features' values setting

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 10.10.17 at 11:19, <yi.y.sun@xxxxxxxxxxxxxxx> wrote:
> --- a/xen/arch/x86/psr.c
> +++ b/xen/arch/x86/psr.c
> @@ -1111,25 +1111,47 @@ static unsigned int get_socket_cpu(unsigned int 
> socket)
>  struct cos_write_info
>  {
>      unsigned int cos;
> -    struct feat_node *feature;
> +    struct feat_node **features;

Why do you need to pass this? Can't do_write_psr_msrs() grab it
via get_socket_info()? I ask not the least because if you pass it,
you want to add const between the two stars to document the
consumer won't alter the array.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel