Re: [Xen-devel] [PATCH v6 3/5] ARM: ITS: Deny hardware domain access to ITS

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 10/10/17 14:53, Manish Jaggi wrote:
> Hi Julien,
>
> On 10/10/2017 7:09 PM, Julien Grall wrote:
> > Hi Manish,
> >
> > On 10/10/17 13:52, mjaggi@xxxxxxxxxxxxxxxxxx wrote:
> > > From: Manish Jaggi <mjaggi@xxxxxxxxxx>
> > >
> > > This patch extends the gicv3_iomem_deny_access functionality by adding
> > > support for ITS region as well. Add function gicv3_its_deny_access.
> > >
> > > Reviewed-by: Andre Przywara <andre.przywara@xxxxxxx>
> > > Acked-by: Julien Grall <julien.grall@xxxxxxx>
> > Please state after "---" when you modified a patch and keep the tags 
> > to at least check if the reviewer is happy with it.
> > It is one of the reason I like the changelog in each patch. It helps 
> > to know what changed in a specific one. It helps me to decide whether 
> > I am happy with you keeping my tag and avoid to fully review yet 
> > another time the patch.
> > In that case, it is fine to keep it.
> For this patch please ack it.
I didn't ask to remove it :). Just pointed out that you should be more 
mindful when keeping an acked-by/reviewed-by.
> Changelog:
> I have added
> - a check on return value for gicv3_its_deny_access(d);
> - used its_data->size in place of GICV3_ITS_SIZE
> - remove extra space in printk
Thank you for the changelog!

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel