Re: [Xen-devel] [PATCH v2] x86: psr: support co-exist features' values setting

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Tue, Oct 10, 2017 at 12:41:40AM +0000, Yi Sun wrote:
> On 17-10-09 15:03:25, Roger Pau Monn� wrote:
> > On Sun, Oct 08, 2017 at 04:22:00AM +0000, Yi Sun wrote:
> [...]
> 
> > >  static void do_write_psr_msrs(void *data)
> > 
> > Should this be "static int do_write_psr_msrs"...
> >
> This function is a parameter of 'on_selected_cpus()' which requires it to be
> 'void'.

IMHO loosing the error code is wrong, so I would suggest storing it
inside of cos_write_info.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel