Re: [Xen-devel] [PATCH v3 7/9] xen/arm: mm: Embed permission in the flags

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 02/10/17 18:31, Julien Grall wrote:
> Currently, it is not possible to specify the permission of a new
> mapping. It would be necessary to use the function modify_xen_mappings
> with a different set of flags.
>
> Introduce a couple of new flags for the permissions (Non-eXecutable,
> Read-Only) and also provides definition that combine the memory attribute
> and permission for common combinations.
>
> PAGE_HYPERVISOR is now an alias to PAGE_HYPERVISOR_RW (read-write,
> non-executable mappings). This does not affect the current mapping using
> PAGE_HYPERVISOR because Xen is currently forcing all the mapping to be
> non-executable by default (see mfn_to_xen_entry).
>
> A follow-up patch will change modify_xen_mappings to use the new flags.
>
> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
During the week-end, I spotted a potential issue with set_fixmap. Indeed 
set_fixmap is supposed to take a memory attribute in parameter. However, 
some callers seem to mix the use of PAGE_* and direct attributes...
I will resend this series with set_fixmap fixed.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel