Re: [Xen-devel] [PATCH v7 08/11] arm: traps: handle PSCI calls inside `vsmc.c`

[Julien Grall <julien.grall@xxxxxxx>]

Hi Volodymyr,

On 04/10/17 22:00, Volodymyr Babchuk wrote:
> +/* helper function for checking arm mode 32/64 bit */
> +static inline int psci_mode_check(struct domain *d, uint32_t fid)
> +{
> +    return !( is_64bit_domain(d)^( (fid & PSCI_0_2_64BIT) >> 30 ) );
> +}
> +
> +/* PSCI 0.2 interface and other Standard Secure Calls */
> +static bool handle_sssc(struct cpu_user_regs *regs)
> +{
> +    uint32_t fid = PSCI_ARG32(regs, 0);
Again, you dropped PSCI_ARG32 in handle_existing_apis and you should do 
it here too as requested in the previous version.
Assuming this will be fixed in the next version:

Acked-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel