[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/7] xen/arm: domain_build: Clean-up insert_11_bank



Hi Andrew,

On 04/10/17 23:39, Andrew Cooper wrote:
On 04/10/2017 19:15, Julien Grall wrote:
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 3723dc3f78..093ebf1a8e 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -109,11 +109,11 @@ static bool insert_11_bank(struct domain *d,
spfn = page_to_mfn(pg);
      start = pfn_to_paddr(spfn);
-    size = pfn_to_paddr((1 << order));
+    size = pfn_to_paddr(1UL << order);
D11PRINT("Allocated %#"PRIpaddr"-%#"PRIpaddr" (%ldMB/%ldMB, order %d)\n",
               start, start + size,
-             1UL << (order+PAGE_SHIFT-20),
+             1UL << (order + PAGE_SHIFT -  20),

If you are looking to be picky, you've got a double space between the
minus and the 20.  I'm sure this would be trivial to fix on commit.

Argh, on my original patch I had 2 spaces before the minus. Dropped one before sending on xen-devel and didn't spot the one after the minus.

I will resend the series with your comments addressed.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.