Re: [Xen-devel] [PATCH v3 5/9] x86/vvmx: make updating shadow EPTP value more efficient

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.10.17 at 10:18, <sergey.dyasli@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/hvm/vmx/entry.S
> +++ b/xen/arch/x86/hvm/vmx/entry.S
> @@ -80,7 +80,7 @@ UNLIKELY_END(realmode)
>          mov  %rsp,%rdi
>          call vmx_vmenter_helper
>          cmp  $0,%eax
> -        jne .Lvmx_vmentry_restart
> +        je .Lvmx_vmentry_restart

If you make the function return bool, the cmp above also needs
changing (and then preferably to "test %al, %al", in which case
it would then also better be "jz" instead of "je").

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel