Re: [Xen-devel] [PATCH v2 07/13] fuzz/x86_emulate: Add 'afl-cov' target

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.10.17 at 18:48, <george.dunlap@xxxxxxxxxx> wrote:
> On 10/04/2017 09:23 AM, Jan Beulich wrote:
>>>>> On 25.09.17 at 16:26, <george.dunlap@xxxxxxxxxx> wrote:
>>>  x86.h := asm/x86-vendors.h asm/x86-defns.h asm/msr-index.h
>>>  x86_emulate.h := x86_emulate_user.h x86_emulate/x86_emulate.h $(x86.h)
>>>  
>>> -x86_emulate_user.o: x86_emulate_user.c x86_emulate/x86_emulate.c 
>>> $(x86_emulate.h)
>>> +X86_EMULATE_INPUTS = x86_emulate_user.c x86_emulate/x86_emulate.c 
>>> $(x86_emulate.h)
>>> +x86_emulate_user.o: $(X86_EMULATE_INPUTS)
>>> +
>>> +x86_emulate_user-cov.o: $(X86_EMULATE_INPUTS)
>>> +   $(CC) -c $(CFLAGS) $(GCOV_FLAGS) -o $@ x86_emulate_user.c
>>>  
>>>  fuzz-emul.o: $(x86_emulate.h)
>>>  
>>> +fuzz-emul-cov.o: fuzz-emul.c $(x86_emulate.h)
>>> +   $(CC) -c $(CFLAGS) $(GCOV_FLAGS) -o $@ fuzz-emul.c
>>> +
>>> +afl-harness-cov.o: afl-harness.c
>>> +   $(CC) -c $(CFLAGS) $(GCOV_FLAGS) $^ -o $@
>> 
>> Rather than effectively repeating this command three time, I think
>> someone else had already suggested to use a pattern rule instead.
> 
> What do you mean "three times"?  There's only  one *-cov.o file which
> can possibly be created by a generic rule, and that's this one.   (The
> others all have special formulas already.)  Is it really worth making a
> generic rule for a single instance?

All three rules could be changed to use $< afaict, and then they're
all identical.

>>> @@ -46,7 +61,7 @@ distclean: clean
>>>  
>>>  .PHONY: clean
>>>  clean:
>>> -   rm -f *.a *.o .*.d afl-harness
>>> +   rm -f *.a *.o .*.d afl-harness afl-harness-cov *.gcda *.gcno *.gcov
>> 
>> Perhaps simply *.gc* to cover for possible future generated file types?
> 
> If I knew that this wouldn't match files like "foo.gcov-notes.txt" I'd
> be fine with it.  I'll change it if you insist but I think it's probably
> better the way it is for now.

Okay, same matter of taste as in the earlier patch. I.e. no, I
won't insist.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel