Re: [Xen-devel] [PATCH 5/7] xen/xenoprof: Convert the file to use typesafe MFN

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 04/10/2017 19:15, Julien Grall wrote:
> @@ -134,25 +140,26 @@ static void xenoprof_reset_buf(struct domain *d)
>  }
>  
>  static int
> -share_xenoprof_page_with_guest(struct domain *d, unsigned long mfn, int 
> npages)
> +share_xenoprof_page_with_guest(struct domain *d, mfn_t mfn, int npages)
>  {
>      int i;
>  
>      /* Check if previous page owner has released the page. */
>      for ( i = 0; i < npages; i++ )
>      {
> -        struct page_info *page = mfn_to_page(mfn + i);
> +        struct page_info *page = mfn_to_page(mfn_add(mfn, i));

A newline would be nice here...

>          if ( (page->count_info & (PGC_allocated|PGC_count_mask)) != 0 )
>          {
>              printk(XENLOG_G_INFO "dom%d mfn %#lx page->count_info %#lx\n",
> -                   d->domain_id, mfn + i, page->count_info);
> +                   d->domain_id, mfn_x(mfn_add(mfn, i)), page->count_info);
>              return -EBUSY;
>          }
>          page_set_owner(page, NULL);
>      }
>  
>      for ( i = 0; i < npages; i++ )
> -        share_xen_page_with_guest(mfn_to_page(mfn + i), d, 
> XENSHARE_writable);
> +        share_xen_page_with_guest(mfn_to_page(mfn_add(mfn, i)),
> +                                  d, XENSHARE_writable);
>  
>      return 0;
>  }
> @@ -161,11 +168,11 @@ static void
>  unshare_xenoprof_page_with_guest(struct xenoprof *x)
>  {
>      int i, npages = x->npages;
> -    unsigned long mfn = virt_to_mfn(x->rawbuf);
> +    mfn_t mfn = virt_to_mfn(x->rawbuf);
>  
>      for ( i = 0; i < npages; i++ )
>      {
> -        struct page_info *page = mfn_to_page(mfn + i);
> +        struct page_info *page = mfn_to_page(mfn_add(mfn, i));

... and here.  This can easily be fixed on commit, so Reviewed-by:
Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

>          BUG_ON(page_get_owner(page) != current->domain);
>          if ( test_and_clear_bit(_PGC_allocated, &page->count_info) )
>              put_page(page);


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel