Re: [Xen-devel] [PATCH v6 06/11] pci: add support to size ROM BARs to pci_size_mem_bar

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.09.17 at 17:29, <roger.pau@xxxxxxxxxx> wrote:
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -610,11 +610,17 @@ int pci_size_mem_bar(pci_sbdf_t sbdf, unsigned int pos, 
> bool last,
>                                             sbdf.func, pos);
>      uint64_t addr, size;
>      bool vf = flags & PCI_BAR_VF;
> -
> -    ASSERT((bar & PCI_BASE_ADDRESS_SPACE) == PCI_BASE_ADDRESS_SPACE_MEMORY);
> +    bool rom = flags & PCI_BAR_ROM;

Ideally with this local variable and ...

> --- a/xen/include/xen/pci.h
> +++ b/xen/include/xen/pci.h
> @@ -191,6 +191,8 @@ const char *parse_pci_seg(const char *, unsigned int 
> *seg, unsigned int *bus,
>  
>  #define _PCI_BAR_VF     0
>  #define PCI_BAR_VF      (1u << _PCI_BAR_VF)
> +#define _PCI_BAR_ROM    1
> +#define PCI_BAR_ROM     (1u << _PCI_BAR_ROM)

... the first of these two dropped
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel