Re: [Xen-devel] [PATCH v2 2/3] xen: RCU: make the period of the idle timer configurable.

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> Dario Faggioli <dario.faggioli@xxxxxxxxxx> 09/28/17 7:17 PM >>>
>On Thu, 2017-09-28 at 07:06 -0600, Jan Beulich wrote:
>> > > > On 28.09.17 at 12:16, <dario.faggioli@xxxxxxxxxx> wrote:
>> > 
>> And then, as a cosmetic thing, idle_timer_period_ms now isn't
>> really needed outside of this function. I'd prefer if you moved it
>> and the integer_param() into this function, to limit their scopes
>> as much as possible.
>> 
>On an unrelated (to this series) note, does this means that patches
>like the one below are welcome/accepted?

Yes, at least I would appreciate any variables in obviously too wide
scopes to be moved into the scope they're really needed in. But as
with most cleanup, I generally prefer such to be done on the go,
unless only very few instances of a certain pattern are left. Even if
such changes generally are relatively easy to review, they still need
looking at and hence consume review bandwidth better imo spent
elsewhere.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel