Re: [Xen-devel] [PATCH 01/27 v11] xen/arm: vpl011: Define common ring buffer helper functions in console.h

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Fri, 29 Sep 2017, Julien Grall wrote:
> Hi Stefano,
> 
> On 09/29/2017 09:10 PM, Stefano Stabellini wrote:
> > On Wed, 27 Sep 2017, Bhupinder Thakur wrote:
> > > DEFINE_XEN_FLEX_RING(xencons) defines common helper functions such as
> > > xencons_queued() to tell the current size of the ring buffer,
> > > xencons_mask() to mask off the index, which are useful helper functions.
> > > pl011 emulation code will use these helper functions.
> > > 
> > > io/console.h includes io/ring.h which defines DEFINE_XEN_FLEX_RING.
> > > 
> > > In console/daemon/io.c, string.h had to be included before io/console.h
> > > because ring.h uses string functions.
> > > 
> > > Signed-off-by: Bhupinder Thakur <bhupinder.thakur@xxxxxxxxxx>
> > > Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > > Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > > Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> > 
> > With the changes you should have probably removed my old reviewed-by.
> > But that's OK:
> > 
> > Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > 
> > If it's OK for everybody, I'll go ahead and commit the series on Monday.
> > Jan, shout if you disagree on something.
> 
> I'd like to have a look at patch #26 and #27. They can be committed separately
> from the rest of the series.

Yes, sorry! I meant commit up to #25.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel