[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen: fail gnttab_grow_table() in case of missing allocations

On Fri, Sep 29, 2017 at 09:02:12AM +0000, Juergen Gross wrote:
> On 29/09/17 10:55, Roger Pau Monné wrote:
> > On Fri, Sep 29, 2017 at 05:39:22AM +0000, Juergen Gross wrote:
> >> +        return 0;
> > 
> > This return 0 has confused me, I was going to ask to return ENODEV,
> > but then I saw this is actually treated like a boolean. Might be good
> > to make gnttab_grow_table return bool, or either make it return proper
> > error codes.
> I wanted to keep the patch small.
> I can either send a cleanup patch after 4.10 or do it in this patch (in
> which case I'd like to know whether this patch or the last one of my
> grant series will be applied first).
> Thoughts?

Oh sorry. It was a rant rather than a request. No need for you to
change this.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.