Re: [Xen-devel] [PATCH v4 05/22] xl: introduce a domain type option

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, Sep 28, 2017 at 01:04:19PM +0000, Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH v4 05/22] xl: introduce a domain type 
> option"):
> > Introduce a new type option to xl configuration files in order to
> > specify the domain type. This supersedes the current builder option.
> > 
> > The new option is documented in the xl.cfg man page, and the previous
> > builder option is marked as deprecated.
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> > +    /* Deprecated since Xen 4.10. */
> > +    if (!xlu_cfg_get_string(config, "builder", &buf, 0)) {
> > +        libxl_domain_type builder_type;
> > +
> > +        if (c_info->type == LIBXL_DOMAIN_TYPE_INVALID)
> > +            fprintf(stderr,
> > +"The \"builder\" option is being deprecated, please use \"type\" 
> > instead.\n");
> > +        if (!strncmp(buf, "hvm", strlen(buf)))
> > +            builder_type = LIBXL_DOMAIN_TYPE_HVM;
> > +        else if (!strncmp(buf, "generic", strlen(buf)))
> > +            builder_type = LIBXL_DOMAIN_TYPE_PV;
> > +        else {
> > +            fprintf(stderr, "Invalid domain type %s.\n", buf);
> > +            exit(1);
> > +        }
> > +
> > +        if (c_info->type != LIBXL_DOMAIN_TYPE_INVALID &&
> > +            c_info->type != builder_type)
> > +        {
>            ^
> 
> > +            fprintf(stderr,
> > +            "Contradicting \"builder\" and \"type\" options specified.\n");
> > +            exit(1);
> 
> Much nicer.  Although one nit: the { on the next line after the if.

Right, I've fixed this, added the Ack and pushed a new branch to my
personal repo:

git://xenbits.xen.org/people/royger/xen.git pvh_tools_v4.1

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel