Re: [Xen-devel] [PATCH 2/2] libxendevicemodel: initialise extent to zero

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Wei Liu [mailto:wei.liu2@xxxxxxxxxx]
> Sent: 28 September 2017 11:24
> To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>; Ian Jackson <Ian.Jackson@xxxxxxxxxx>;
> Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> Subject: [PATCH 2/2] libxendevicemodel: initialise extent to zero
> 
> The pad field needs to be zero as required by the hypervisor.
> 
> Instead of setting the pad separately, memset extent to zero.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Paul Durrant <paul.durrant@xxxxxxxxxx>
> 
> Backport to 4.9
> ---
>  tools/libs/devicemodel/core.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/libs/devicemodel/core.c b/tools/libs/devicemodel/core.c
> index fcb260d29b..af06936262 100644
> --- a/tools/libs/devicemodel/core.c
> +++ b/tools/libs/devicemodel/core.c
> @@ -485,6 +485,8 @@ int xendevicemodel_modified_memory(
>  {
>      struct xen_dm_op_modified_memory_extent extent;
> 
> +    memset(&extent, 0, sizeof(extent));
> +

Probably better to just use a C99 initializer instead so the compiler deals 
with the pad.

  Paul

>      extent.first_pfn = first_pfn;
>      extent.nr = nr;
> 
> --
> 2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel