Re: [Xen-devel] [PATCH v4 02/15] Rename PSR sysctl/domctl interfaces and xsm policy to make them be general

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Sep 28, 2017 at 10:12:08AM +0800, Yi Sun wrote:
> On 17-09-26 15:19:19, Wei Liu wrote:
> > On Sat, Sep 23, 2017 at 05:48:11PM +0800, Yi Sun wrote:
> > > This patch renames PSR sysctl/domctl interfaces and related xsm policy to
> > > make them be general for all resource allocation features but not only
> > > for CAT. Then, we can resuse the interfaces for all allocation features.
> > > 
> > > Basically, it changes 'psr_cat_op' to 'psr_alloc', and remove 'CAT_' from 
> > > some
> > > macros. E.g.:
> > > 1. psr_cat_op -> psr_alloc
> > > 2. XEN_DOMCTL_psr_cat_op -> XEN_DOMCTL_psr_alloc
> > > 3. XEN_SYSCTL_psr_cat_op -> XEN_SYSCTL_psr_alloc
> > > 4. XEN_DOMCTL_PSR_CAT_SET_L3_CBM -> XEN_DOMCTL_PSR_SET_L3_CBM
> > > 5. XEN_SYSCTL_PSR_CAT_get_l3_info -> XEN_SYSCTL_PSR_get_l3_info
> > > 
> > > The sysctl/domctl version numbers are bumped.
> > > 
> > > Signed-off-by: Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx>
> > > Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > > Acked-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
> > 
> > Normally if there have been substantive changes you should drop the
> > reviews.  It seems to be the case. I will need to review this patch
> > again.
> 
> Sorry for that.
> 
> I thought they were just name changes. So I did not drop reviews. But
> this patch's main purpose is 'rename'. I should drop reviews. Will
> notice this.

No need to be sorry, really. This isn't something that can be documented
clearly.

If unsure, always drop the tags in the future.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel