Re: [Xen-devel] [PATCH v4 00/15] Enable Memory Bandwidth Allocation in Xen

[Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx>]

On 17-09-26 12:48:29, Roger Pau Monn� wrote:
> On Sat, Sep 23, 2017 at 09:48:09AM +0000, Yi Sun wrote:
> > Hi, all,
> > 
> > We plan to bring a new PSR (Platform Shared Resource) feature called
> > Intel Memory Bandwidth Allocation (MBA) to Xen.
> > 
> > Besides the MBA enabling, we change some interfaces to make them more
> > general but not only for CAT.
> 
> As a general comment, I'm quite amused by the huge amount of code
> movement and name changes that's needed in order to implement this
> 'simple' feature. In the future it would be good if things like this
> (adding another feature to an existing interface) is not so painful. I
> hope that with this change all the PSR infrastructure is flexible
> enough to support upcoming PSR features, in case there are more.
> 
I understand your concerns. The original codes are specificlly designed for
only L3 CAT. So, it is not easy to add new feature. That is why I refactored
PSR codes to provide a extendible framework in hypervisor through L2 CAT patch
set. But L2 CAT is also a CAT feature. When the first versions of L2 CAT patch
set were submitted, the MBA was not published yet. To avoid confusion to the
codes and extra argument, I kept many old names and interfaces in tools.

Now, MBA has been published. So, I made such 'huge amount of code movement and
name changes' to try to cover all PSR features. The purpose is to provide an
extendible framework and generic interfaces.

> Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel