Re: [Xen-devel] [PATCH v5] x86/hvm: Implement hvmemul_write() using real mappings

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 27/09/17 12:48, Alexandru Stefan ISAILA wrote:
> On Mi, 2017-09-27 at 09:38 +0100, Andrew Cooper wrote:
>> On 27/09/2017 09:04, Alexandru Isaila wrote:
>>> From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>>>
>>>
>>> -        return X86EMUL_EXCEPTION;
>>> -    case HVMTRANS_bad_gfn_to_mfn:
>>> -        return hvmemul_linear_mmio_write(addr, bytes, p_data,
>>> pfec, hvmemul_ctxt, 0);
>> Where has the if ( !mapping ) test gone?  The HVMTRANS_bad_gfn_to_mfn
>> case needs handling.
> There was a comment form Jan in V2. NOTE: "v1
> comment:'Pointless"else".'"

That means that the "else " text is pointless, not the clause.  (Jan:
Please do try to be clearer when stating "pointless else", because it
really is ambiguous and this mistake is a valid interpretation of your
statement.)

The call to hvmemul_linear_mmio_write(addr, bytes, p_data, pfec,
hvmemul_ctxt, 0); is important, and needs to stay.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel