Re: [Xen-devel] [PATCH 27/27 v10] xen/arm: vpl011: Correct the logic for asserting/de-asserting SBSA UART TX interrupt

[Dave Martin <Dave.Martin@xxxxxxx>]

On Tue, Sep 26, 2017 at 04:50:44PM +0100, Julien Grall wrote:
> Hi Dave,
> 
> On 09/26/2017 03:38 PM, Dave Martin wrote:
> >On Fri, Sep 22, 2017 at 01:53:26PM +0530, Bhupinder Thakur wrote:
> >>This patch fixes the issue observed when pl011 patches were tested on
> >>the junos hardware by Andre/Julien. It was observed that when large output 
> >>is

[...]

> >(Taking a quick look at this because I remember fighthing with FIFO
> >behaviour issues when hacking the Linux driver -- but beware, I'm not a
> >Xen guy...)
> >
> >
> >Should this patch be flattened into the patches is fixes?  Keeping
> >known-wrong code in the series does not help reviewers (but maybe it's
> >the Xen way).
> 
> We usually prefer to have patch fold into the patches it fixes. However, I
> specifically ask Bhupinder to do a follow-up because the rest of the series
> is nearly ready.
> 
> So we could merge the first 25 patches before the code freeze as the two
> other could be considered as bug fixes. This would allow us to get PL011
> support in Xen 4.10.

That's fair -- I jumped into the series without much context, because
I remember "fixing" the pl011 driver in this area in the past.

Cheers
---Dave

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel