Re: [Xen-devel] [PATCH] x86/levelling: Avoid NULL pointer dereference

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.09.17 at 18:28, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/cpu/intel.c
> +++ b/xen/arch/x86/cpu/intel.c
> @@ -156,7 +156,6 @@ static void intel_ctxt_switch_levelling(const struct vcpu 
> *next)
>       struct cpuidmasks *these_masks = &this_cpu(cpuidmasks);
>       const struct domain *nextd = next ? next->domain : NULL;
>       const struct cpuidmasks *masks;
> -     const struct msr_vcpu_policy *vp = next->arch.msr;
>  
>       if (cpu_has_cpuid_faulting) {

And patch context (specifically the same here as for the offending
patch) even shows that next is being checked against NULL. Yet
none of us did notice.

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel