[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] libxc: remove stale error check for domain size in xc_sr_save_x86_hvm.c

Long ago domains to be saved were limited to 1TB size due to the
migration stream v1 limitations which used a 32 bit value for the
PFN and the frame type (4 bits) leaving only 28 bits for the PFN.

Migration stream V2 uses a 64 bit value for this purpose, so there
is no need to refuse saving (or migrating) domains larger than 1 TB.

Remove the related test in xc_sr_save_x86_hvm.c

Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
I know we have code freeze. Nevertheless I'd like to request an
exception and get this into 4.10, as the impact of the patch is
very local and of low risk.
 tools/libxc/xc_sr_save_x86_hvm.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/tools/libxc/xc_sr_save_x86_hvm.c b/tools/libxc/xc_sr_save_x86_hvm.c
index e17bb59146..13e48867ce 100644
--- a/tools/libxc/xc_sr_save_x86_hvm.c
+++ b/tools/libxc/xc_sr_save_x86_hvm.c
@@ -148,12 +148,6 @@ static int x86_hvm_setup(struct xc_sr_context *ctx)
         PERROR("Unable to obtain the guest p2m size");
         return -1;
-    if ( nr_pfns > ~XEN_DOMCTL_PFINFO_LTAB_MASK )
-    {
-        errno = E2BIG;
-        PERROR("Cannot save this big a guest");
-        return -1;
-    }
     ctx->save.p2m_size = nr_pfns;

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.