Re: [Xen-devel] [PATCH v9 09/10] xen: make grant resource limits per domain

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.09.17 at 19:50, <jgross@xxxxxxxx> wrote:
> On 22/09/17 17:15, Jan Beulich wrote:
>>>>> On 22.09.17 at 13:41, <jgross@xxxxxxxx> wrote:
>>> @@ -1672,8 +1670,8 @@ gnttab_grow_table(struct domain *d, unsigned int 
>>> req_nr_frames)
>>>      ASSERT(gt->active);
>>>  
>>>      if ( req_nr_frames < INITIAL_NR_GRANT_FRAMES )
>>> -        req_nr_frames = INITIAL_NR_GRANT_FRAMES;
>>> -    ASSERT(req_nr_frames <= max_grant_frames);
>>> +        req_nr_frames = min(INITIAL_NR_GRANT_FRAMES, gt->max_grant_frames);
>> 
>> I'm not convinced of this: You effectively allowing a zero size grant
>> table this way. I'd prefer if the "initial" constant stayed the lower
>> bound. I'm open to lowering that initial value, though.
> 
> Okay. What about the value "1" for it? Should be enough for e.g.
> stubdoms, dom0, ...

Yes, 1 is fine with me.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel